Skip to content

STY: Tweak PdfWriter #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

STY: Tweak PdfWriter #3337

wants to merge 8 commits into from

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jun 28, 2025

Small changes including making method insert_blank_page more flexible.

j-t-1 added 2 commits June 28, 2025 08:54
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ed645ca). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3337   +/-   ##
=======================================
  Coverage        ?   96.73%           
=======================================
  Files           ?       53           
  Lines           ?     9062           
  Branches        ?     1678           
=======================================
  Hits            ?     8766           
  Misses          ?      177           
  Partials        ?      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator

Could you please have a look at the coverage? All (new) conditions should be covered be appropriate tests.

@stefan6419846 stefan6419846 added the needs-test A test should be added before this PR is merged. label Jun 28, 2025
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
j-t-1 added 3 commits June 28, 2025 12:37
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-test A test should be added before this PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants